Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import error in torchtune due to bc breaking changes in torchao #1817

Closed
wants to merge 1 commit into from
Closed

Fix import error in torchtune due to bc breaking changes in torchao #1817

wants to merge 1 commit into from

Conversation

jerryzh168
Copy link
Contributor

Summary: att

Differential Revision: D64261315

@jerryzh168 @facebook-github-bot
Fix import error in torchtune due to bc breaking changes in torchao
2c559c6 
Summary: att

Differential Revision: D64261315
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 11, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchtune/1817

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 New Failures, 1 Cancelled Job, 2 Unrelated Failures

As of commit 2c559c6 with merge base 50d3ef1 (image):

NEW FAILURES - The following jobs have failed:

  • Build Docs / build_docs (3.11) (gh)
    sphinx.ext.autosummary.ImportExceptionGroup: no module named torchtune.training
  • GPU tests / gpu_test (3.10, stable) (gh)
    E ImportError: cannot import name 'TensorCoreTiledLayout' from 'torchao.dtypes' (/home/ec2-user/actions-runner/_work/torchtune/torchtune/3/envs/test/lib/python3.10/site-packages/torchao/dtypes/__init__.py)
  • GPU tests / gpu_test (3.9, stable) (gh)
    E ImportError: cannot import name 'TensorCoreTiledLayout' from 'torchao.dtypes' (/home/ec2-user/actions-runner/_work/torchtune/torchtune/3/envs/test/lib/python3.9/site-packages/torchao/dtypes/__init__.py)
  • Recipe Tests / recipe_test (3.11) (gh)
    E ImportError: cannot import name 'TensorCoreTiledLayout' from 'torchao.dtypes' (/usr/share/miniconda3/envs/test/lib/python3.11/site-packages/torchao/dtypes/__init__.py)
  • Recipe Tests / recipe_test (3.9) (gh)
    E ImportError: cannot import name 'TensorCoreTiledLayout' from 'torchao.dtypes' (/usr/share/miniconda3/envs/test/lib/python3.9/site-packages/torchao/dtypes/__init__.py)
  • Unit Test / unit_tests (3.10) (gh)
    E ImportError: cannot import name 'TensorCoreTiledLayout' from 'torchao.dtypes' (/usr/share/miniconda3/envs/test/lib/python3.10/site-packages/torchao/dtypes/__init__.py)
  • Unit Test / unit_tests (3.9) (gh)
    E ImportError: cannot import name 'TensorCoreTiledLayout' from 'torchao.dtypes' (/usr/share/miniconda3/envs/test/lib/python3.9/site-packages/torchao/dtypes/__init__.py)

CANCELLED JOB - The following job was cancelled. Please retry:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following job failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2024
@facebook-github-bot
Copy link

This pull request was exported from Phabricator. Differential Revision: D64261315

@jerryzh168
Copy link
Contributor Author

real fix in #1812

@jerryzh168 jerryzh168 closed this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jerryzh168 @facebook-github-bot